lkml.org 
[lkml]   [2020]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] gpio: mockup: pass the chip label as device property
On Thu, Sep 24, 2020 at 01:38:40PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> While we do check the "chip-name" property in probe(), we never actually
> use it. Let's pass the chip label to the driver using device properties
> as we'll want to allow users to define their own once dynamically
> created chips are supported.
>
> The property is renamed to "chip-label" to not cause any confusion with
> the actual chip name which is of the form: "gpiochipX".
>
> If the "chip-label" property is missing, let's do what most devices in
> drivers/gpio/ do and use dev_name().

...

> + properties[prop++] = PROPERTY_ENTRY_STRING("chip-label",
> + chip_label);

Forgot to update GPIO_MOCKUP_MAX_PROP?

> base = gpio_mockup_range_base(i);
> if (base >= 0)
> properties[prop++] = PROPERTY_ENTRY_U32("gpio-base",

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-09-25 11:00    [W:0.084 / U:2.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site