lkml.org 
[lkml]   [2020]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 18/22] kvm: mmu: Support disabling dirty logging for the tdp MMU
From
Date
On 25/09/20 23:22, Ben Gardon wrote:
> + for_each_tdp_pte_root(iter, root, start, end) {
> + if (!is_shadow_present_pte(iter.old_spte) ||
> + is_last_spte(iter.old_spte, iter.level))
> + continue;
> +

I'm starting to wonder if another iterator like
for_each_tdp_leaf_pte_root would be clearer, since this idiom repeats
itself quite often. The tdp_iter_next_leaf function would be easily
implemented as

while (likely(iter->valid) &&
(!is_shadow_present_pte(iter.old_spte) ||
is_last_spte(iter.old_spte, iter.level))
tdp_iter_next(iter);

Paolo

\
 
 \ /
  Last update: 2020-09-26 03:09    [W:0.544 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site