lkml.org 
[lkml]   [2020]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] perf vendor events: Update CascadelakeX events to v1.08
Em Fri, Sep 25, 2020 at 11:36:15AM -0700, Andi Kleen escreveu:
> > Thanks, it now works, but then... You forgot to add the Cc: entries for
> > all the people in your actual e-mail Cc: list, and also the
> > Reviewed-by: from Andy, I had to do it all manually, so when I applied
> > your attachments with 'git am' I needed to go on and manually collect
> > all the Cc, Reviewed-by and Acked-by tags.
>
> For the event updates we should just use git pulls in my opinion.
>
> They are just too large for the normal review procedures, and usually
> don't really benefit much from community review anyways because they
> are essentially hardware documentation.
>
> Should just name intel / amd / etc. event list maintainers and you
> could accept pulls from them.

That isn't that important, i.e. if I do it from e-mail manually or doing
a git pull.

What is important is that one person submits, another provides some
stamp, the stamp is collected, patch is applied and build tested, life
goes on.

b4 should fix this all up, but attachments, in this case, seems to be
needed due to the content having such long lines, right?

- Arnaldo

\
 
 \ /
  Last update: 2020-09-25 22:41    [W:0.102 / U:5.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site