| Subject | Re: [PATCH RFT/RFC v2 11/47] staging: media: zoran: zoran_device.c: convert pr_x to pci_x | From | Joe Perches <> | Date | Fri, 25 Sep 2020 11:36:03 -0700 |
| |
On Fri, 2020-09-25 at 18:30 +0000, Corentin Labbe wrote: > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> [] > diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c [] > @@ -198,15 +198,14 @@ void detect_guest_activity(struct zoran *zr) [] > for (i = 0; i < j; i++) > - pr_info("%s: %6d: %d => 0x%02x\n", ZR_DEVNAME(zr), > - change[i][0], change[i][1], change[i][2]);
> + pci_info(zr->pci_dev, "%6d: %d => 0x%02x\n", change[i][0], change[i][1], change[i][2]);
IMO: this change does little for readability or makes it worse. Can you please keep to 80 columns where it's already 80 columns?
|