Messages in this thread | | | From | Shakeel Butt <> | Date | Thu, 24 Sep 2020 12:44:57 -0700 | Subject | Re: [PATCH v2 3/4] mm: introduce page memcg flags |
| |
On Thu, Sep 24, 2020 at 12:29 PM Roman Gushchin <guro@fb.com> wrote: > > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg flags, defined in page_memcg_flags > enum, and replace all open-coded accesses with test_bit()/__set_bit(). > > Additional flags might be added later. > > Signed-off-by: Roman Gushchin <guro@fb.com>
Thanks.
Reviewed-by: Shakeel Butt <shakeelb@google.com>
| |