lkml.org 
[lkml]   [2020]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema
Date
Hi Geert,

Thank you for getting back to me.

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 September 2020 14:33
>
> Hi Fabrizio,
>
> On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> > > <fabrizio.castro.jz@renesas.com> wrote:
> > > > Convert the Renesas DRIF bindings to DT schema and update
> > > > MAINTAINERS accordingly.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> > > > +if:
> > > > + required:
> > > > + - renesas,primary-bond
> > > > +then:
> > > > + required:
> > > > + - pinctrl-0
> > > > + - pinctrl-names
> > > > + - port
> > >
> > > The last 3 properties must not be present for a secondary interface,
> > > right?
> >
> > If you have both channels enabled, then one of the two has to define
> properties:
> > * renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
> >
> > If only one channel is enabled, then the primary bond concept loses its
> value,
> > whether renesas,primary-bond is specified or not doesn’t matter anymore,
> but the
> > enabled node has to specify the pinctrl related properties and the port.
> >
> > > To express that, I think you need to add:
> > >
> > > else:
> > > properties:
> > > - pinctrl-0: false
> > > - pinctrl-names: false
> > > - port: false
> >
> > If I went with this, we would not be able to allow those properties to be
> specified in the
> > only enabled node for single channels configurations.
> >
> > Is there a better way to approach this?
> >
> > I'll wait for this point to get sorted before sending v3 out.
>
> The old binding said:
>
> -Required properties of an internal channel when:
> - - It is the only enabled channel of the bond (or)
> - - If it acts as primary among enabled bonds
>
> -- renesas,primary-bond: empty property indicating the channel
> acts as primary
> - among the bonded channels.
>
> so renesas,primary-bond is required for the only enabled node for
> single channels configurations anyway?

The old binding also said:
"
When only one of the bonded channels need to be enabled, the property
"renesas,bonding" or "renesas,primary-bond" will have no effect. That
enabled channel can act alone as any other independent device.
"

If you then look at the driver implementation, the renesas,primary-bond
property doesn’t get evaluated if you have only one channel enabled.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
\
 
 \ /
  Last update: 2020-09-23 16:09    [W:0.053 / U:4.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site