Messages in this thread | | | Subject | Re: [PATCH 1/4] dt-bindings: clock: Add support for LPASS Audio Clock Controller | From | Srinivas Kandagatla <> | Date | Wed, 23 Sep 2020 11:25:16 +0100 |
| |
Hi Rob,
On 18/09/2020 18:29, Rob Herring wrote: > On Thu, 17 Sep 2020 14:28:47 +0100, Srinivas Kandagatla wrote: >> Audio Clock controller is a block inside LPASS which controls >> 2 Glitch free muxes to LPASS codec Macros. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> .../bindings/clock/qcom,audiocc-sm8250.yaml | 58 +++++++++++++++++++ >> .../clock/qcom,sm8250-lpass-audiocc.h | 13 +++++ >> 2 files changed, 71 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml >> create mode 100644 include/dt-bindings/clock/qcom,sm8250-lpass-audiocc.h >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.example.dts:25.30-31 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1366: dt_binding_check] Error 2 >
Is this check done against linux-next?
or linux master?
I have rechecked this once again on next and I see no check failures. Next has a patch [1] which adds defines in header file that are used in example! Possibly that is what is making the check fail!
thanks, srini
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200922&id=4e398353a7e51410c34fd19f8b7dfc56fff5901b
> > See https://patchwork.ozlabs.org/patch/1366127 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. >
| |