Messages in this thread | | | From | <> | Subject | Re: [PATCH 1/7] dmaengine: at_xdmac: separate register defines into header file | Date | Wed, 23 Sep 2020 05:07:54 +0000 |
| |
Hi, Eugen,
On 9/14/20 5:09 PM, Eugen Hristev wrote: > Separate register defines into header file. > This is required to support a slightly different version of the register > map in new hardware versions of the XDMAC. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > drivers/dma/at_xdmac.c | 143 +-------------------------------- > drivers/dma/at_xdmac_regs.h | 154 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 155 insertions(+), 142 deletions(-) > create mode 100644 drivers/dma/at_xdmac_regs.h
Even with the sama7g5 support there is a single .c file that includes the .h. I wouldn't split the registers definitions in a dedicated file.
Cheers, ta
| |