lkml.org 
[lkml]   [2020]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH printk 3/5] printk: use buffer pool for sprint buffers
On (20/09/22 17:44), John Ogness wrote:
[..]
> int vprintk_store(int facility, int level,
> const struct dev_printk_info *dev_info,
> const char *fmt, va_list args)
> {
> - static char textbuf[LOG_LINE_MAX];
> - char *text = textbuf;
> size_t text_len;
> enum log_flags lflags = 0;
> + unsigned long irqflags;
> + int sprint_id;
> + char *text;
> + int ret;
> +
> + text = get_sprint_buf(&sprint_id, &irqflags);
> + if (WARN_ON_ONCE(!text))
> + return 0;

So we failed to get the buffer. How likely that this recursive
WARN_ON_ONCE()->printk()->get_sprint_buf() will be able to get one?
I would rather expect that we will entirely lose WARN_ON_ONCE().

-ss

\
 
 \ /
  Last update: 2020-09-24 03:23    [W:0.195 / U:4.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site