Messages in this thread | | | From | Tianxianting <> | Subject | RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null | Date | Tue, 22 Sep 2020 15:27:27 +0000 |
| |
Thank you Keith, Christoph, So I don't need to send v3 patch?
-----Original Message----- From: Christoph Hellwig [mailto:hch@lst.de] Sent: Tuesday, September 22, 2020 10:59 PM To: Keith Busch <kbusch@kernel.org> Cc: tianxianting (RD) <tian.xianting@h3c.com>; axboe@fb.com; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null
On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote: > The commit subject is a too long. We should really try to keep these > to > 50 characters or less. > > nvme-pci: fix NULL req in completion handler > > Otherwise, looks fine. > > Reviewed-by: Keith Busch <kbusch@kernel.org>
Yes. I was about to apply it with a similar edit, but I'll take yours happily.
| |