lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"
From
Date

> On Sep 21, 2020, at 16:40, Takashi Iwai <tiwai@suse.de> wrote:
>
> On Tue, 15 Sep 2020 12:39:23 +0200,
> Kai-Heng Feng wrote:
>>
>> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
>>
>> According to Realtek, volume FU works for line-in.
>>
>> I can confirm volume control works after device firmware is updated.
>
> A slight concern is what happens if you apply this change to the
> device before the firmware update.

The desktop that equips with the USB audio device hasn't released to the market yet, so I am not really worried about this.

>
> Also, after this revert, does the mixer control appear properly?

Yes it does.

Kai-Heng

>
>
> thanks,
>
> Takashi
>
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> sound/usb/mixer_maps.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
>> index 5b43e9e40e49..c369c81e74c4 100644
>> --- a/sound/usb/mixer_maps.c
>> +++ b/sound/usb/mixer_maps.c
>> @@ -371,7 +371,6 @@ static const struct usbmix_name_map asus_rog_map[] = {
>> };
>>
>> static const struct usbmix_name_map lenovo_p620_rear_map[] = {
>> - { 19, NULL, 2 }, /* FU, Volume */
>> { 19, NULL, 12 }, /* FU, Input Gain Pad */
>> {}
>> };
>> --
>> 2.17.1
>>

\
 
 \ /
  Last update: 2020-09-22 17:14    [W:0.045 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site