[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH AUTOSEL 5.4 13/15] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is
On Mon, Sep 21, 2020 at 04:48:05PM +0200, Michel Dänzer wrote:
>On 2020-09-21 4:40 p.m., Sasha Levin wrote:
>>From: Michel Dänzer <>
>>[ Upstream commit 2f228aab21bbc74e90e267a721215ec8be51daf7 ]
>>Don't check drm_crtc_state::active for this either, per its
>>documentation in include/drm/drm_crtc.h:
>> * Hence drivers must not consult @active in their various
>> * &drm_mode_config_funcs.atomic_check callback to reject an atomic
>> * commit.
>>atomic_remove_fb disables the CRTC as needed for disabling the primary
>>This prevents at least the following problems if the primary plane gets
>>disabled (e.g. due to destroying the FB assigned to the primary plane,
>>as happens e.g. with mutter in Wayland mode):
>>* The legacy cursor ioctl returned EINVAL for a non-0 cursor FB ID
>> (which enables the cursor plane).
>>* If the cursor plane was enabled, changing the legacy DPMS property
>> value from off to on returned EINVAL.
>>* Minor changes to code comment and commit log, per review feedback.
>>Suggested-by: Daniel Vetter <>
>>Acked-by: Daniel Vetter <>
>>Reviewed-by: Nicholas Kazlauskas <>
>>Signed-off-by: Michel Dänzer <>
>>Signed-off-by: Alex Deucher <>
>>Signed-off-by: Sasha Levin <>
>I'm a bit nervous about this getting backported so far back so
>quickly. I'd prefer waiting for 5.9 final first at least.

Will drop it for now, thanks.


 \ /
  Last update: 2020-09-22 16:25    [W:0.032 / U:21.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site