lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] btrfs: fix memdup.cocci warnings
On Tue, Sep 22, 2020 at 11:29 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> fs/btrfs/send.c:3854:8-15: WARNING opportunity for kmemdup
>
> Use kmemdup rather than duplicating its implementation
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Fixes: 28314eb24e6c ("btrfs: send, recompute reference path after orphanization of a directory")
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Since this is not in Linus' tree yet, it can be folded in the original patch.
David, can you do that when you pick it?

Btw, isn't the Fixes tag meant only for bug fixes? This is a pure
cleanup afaics.

Thanks.

> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.git misc-next
> head: 28314eb24e6cb8124d1e5da2ef2ccb90ec44cc06
> commit: 28314eb24e6cb8124d1e5da2ef2ccb90ec44cc06 [2/2] btrfs: send, recompute reference path after orphanization of a directory
> :::::: branch date: 17 hours ago
> :::::: commit date: 17 hours ago
>
>
> send.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -3851,10 +3851,9 @@ static int refresh_ref_path(struct send_
> char *name;
> int ret;
>
> - name = kmalloc(ref->name_len, GFP_KERNEL);
> + name = kmemdup(ref->name, ref->name_len, GFP_KERNEL);
> if (!name)
> return -ENOMEM;
> - memcpy(name, ref->name, ref->name_len);
>
> fs_path_reset(ref->full_path);
> ret = get_cur_path(sctx, ref->dir, ref->dir_gen, ref->full_path);



--
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

\
 
 \ /
  Last update: 2020-09-22 16:07    [W:0.091 / U:2.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site