[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()
On 14/09/20 22:43, Krish Sadhukhan wrote:
> Not related to your changes, but should we get rid of the variable
> 'exit_fastpath' and just do,
>         return svm_exit_handler_fastpath(vcpu);
> It seems the variable isn't used anywhere else and svm_vcpu_run()
> doesn't return from anywhere else either.

Yes (also because vmx will do the same once we can push
EXIT_FASTPATH_REENTER_GUEST handling up to vcpu_enter_guest)...

> Also, svm_exit_handlers_fastpath() doesn't have any other caller. 
> Should we get rid of it as well ?

... and no, because svm_vcpu_run is a very large function and therefore
it's better to keep its flow streamlined.


 \ /
  Last update: 2020-09-22 15:44    [W:0.055 / U:3.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site