lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/33] Make charlcd device independent
Hi Lars,

On Mon, Sep 21, 2020 at 04:46:12PM +0200, poeschel@lemonage.de wrote:
> This tries to make charlcd device independent. At the moment hd44780
> device specific code is contained deep in charlcd. This moves this out
> into a hd44780_common module, where the two hd44780 drivers we have at
> the moment (hd44780 and panel) can use this from. The goal is that at
> the end other drivers can use the charlcd interface.
> I add one such driver at the end with the last patch.
> I submitted this already some time ago [1], where the wish was so split
> this into smaller chunks what I try to do with this new patchset.
> Most of the patches pick one specific function in charlcd and move the
> device specific code into hd44780_common.

Regardless of my two comments, this series looks very clean to me, nice
job! For 1..32, feel free to add: Reviewed-by: Willy Tarreau <w@1wt.eu>

Just be careful in your commit messages, I spotted a few "it's own"
instead of "its own", but that's a very minor detail :-)

Willy

\
 
 \ /
  Last update: 2020-09-22 07:33    [W:0.245 / U:2.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site