lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE
From
Date
On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

> drivers/mfd/bcm2835-pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
> index 42fe67f1538e..a76014512bde 100644
> --- a/drivers/mfd/bcm2835-pm.c
> +++ b/drivers/mfd/bcm2835-pm.c
> @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
> if (IS_ERR(pm->base))
> return PTR_ERR(pm->base);
>
> - ret = devm_mfd_add_devices(dev, -1,
> + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs),
> NULL, 0, NULL);
> if (ret)
> @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
> if (IS_ERR(pm->asb))
> return PTR_ERR(pm->asb);
>
> - ret = devm_mfd_add_devices(dev, -1,
> + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> bcm2835_power_devs,
> ARRAY_SIZE(bcm2835_power_devs),
> NULL, 0, NULL);

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-22 12:35    [W:0.171 / U:23.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site