Messages in this thread | | | Subject | Re: [PATCH -next] powerpc/perf: Fix symbol undeclared warning | From | Athira Rajeev <> | Date | Wed, 23 Sep 2020 07:48:22 +0530 |
| |
> On 21-Sep-2020, at 4:55 PM, Wang Wensheng <wangwensheng4@huawei.com> wrote: > > Build kernel with `C=2`: > arch/powerpc/perf/isa207-common.c:24:18: warning: symbol > 'isa207_pmu_format_attr' was not declared. Should it be static? > arch/powerpc/perf/power9-pmu.c:101:5: warning: symbol 'p9_dd21_bl_ev' > was not declared. Should it be static? > arch/powerpc/perf/power9-pmu.c:115:5: warning: symbol 'p9_dd22_bl_ev' > was not declared. Should it be static?
Hi,
It will be good to include a comment in the commit message saying what is the fix here. ex, declare p9_dd21_bl_ev/p9_dd22_bl_ev as static variable.
Thanks Athira > > Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> > --- > arch/powerpc/perf/isa207-common.c | 2 +- > arch/powerpc/perf/power9-pmu.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c > index 964437adec18..85dc860b265b 100644 > --- a/arch/powerpc/perf/isa207-common.c > +++ b/arch/powerpc/perf/isa207-common.c > @@ -21,7 +21,7 @@ PMU_FORMAT_ATTR(thresh_stop, "config:32-35"); > PMU_FORMAT_ATTR(thresh_start, "config:36-39"); > PMU_FORMAT_ATTR(thresh_cmp, "config:40-49"); > > -struct attribute *isa207_pmu_format_attr[] = { > +static struct attribute *isa207_pmu_format_attr[] = { > &format_attr_event.attr, > &format_attr_pmcxsel.attr, > &format_attr_mark.attr, > diff --git a/arch/powerpc/perf/power9-pmu.c b/arch/powerpc/perf/power9-pmu.c > index 2a57e93a79dc..4a315fad1f99 100644 > --- a/arch/powerpc/perf/power9-pmu.c > +++ b/arch/powerpc/perf/power9-pmu.c > @@ -98,7 +98,7 @@ extern u64 PERF_REG_EXTENDED_MASK; > /* PowerISA v2.07 format attribute structure*/ > extern struct attribute_group isa207_pmu_format_group; > > -int p9_dd21_bl_ev[] = { > +static int p9_dd21_bl_ev[] = { > PM_MRK_ST_DONE_L2, > PM_RADIX_PWC_L1_HIT, > PM_FLOP_CMPL, > @@ -112,7 +112,7 @@ int p9_dd21_bl_ev[] = { > PM_DISP_HELD_SYNC_HOLD, > }; > > -int p9_dd22_bl_ev[] = { > +static int p9_dd22_bl_ev[] = { > PM_DTLB_MISS_16G, > PM_DERAT_MISS_2M, > PM_DTLB_MISS_2M, > -- > 2.25.0 >
| |