lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] counter: microchip-tcb-capture: Constify mchp_tc_ops
On Tue, Sep 22, 2020 at 10:19:41PM +0200, Rikard Falkeborn wrote:
> The only usage of mchp_tc_ops is to assign its address to the ops field
> in the counter_device struct which is a const pointer. Make it const to
> allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
> drivers/counter/microchip-tcb-capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index b7b252c5addf..039c54a78aa5 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -253,7 +253,7 @@ static struct counter_count mchp_tc_counts[] = {
> },
> };
>
> -static struct counter_ops mchp_tc_ops = {
> +static const struct counter_ops mchp_tc_ops = {
> .signal_read = mchp_tc_count_signal_read,
> .count_read = mchp_tc_count_read,
> .function_get = mchp_tc_count_function_get,
> --
> 2.28.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-23 03:50    [W:0.040 / U:5.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site