lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: microchip: Make `lan743x_pm_suspend` function return right value
From
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Mon, 21 Sep 2020 20:08:18 +0800

> @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
> /* Host sets PME_En, put D3hot */
> ret = pci_prepare_to_sleep(pdev);
>
> - return 0;
> + return ret;
> }

Instead please do:

return pci_preprare_to_sleep(pdev);

And if 'ret' is then completely unused as a result, remove it.

\
 
 \ /
  Last update: 2020-09-23 01:55    [W:0.029 / U:3.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site