Messages in this thread | | | Subject | Re: [PATCH -next] virt: vbox: simplify the return expression of vbg_input_open() | From | Hans de Goede <> | Date | Mon, 21 Sep 2020 15:33:59 +0200 |
| |
Hi,
On 9/21/20 3:11 PM, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/virt/vboxguest/vboxguest_linux.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c > index 6215a688e..73eb34849 100644 > --- a/drivers/virt/vboxguest/vboxguest_linux.c > +++ b/drivers/virt/vboxguest/vboxguest_linux.c > @@ -202,13 +202,8 @@ static int vbg_input_open(struct input_dev *input) > { > struct vbg_dev *gdev = input_get_drvdata(input); > u32 feat = VMMDEV_MOUSE_GUEST_CAN_ABSOLUTE | VMMDEV_MOUSE_NEW_PROTOCOL; > - int ret; > > - ret = vbg_core_set_mouse_status(gdev, feat); > - if (ret) > - return ret; > - > - return 0; > + return vbg_core_set_mouse_status(gdev, feat); > } > > /** >
| |