Messages in this thread | | | Date | Mon, 21 Sep 2020 14:29:18 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params |
| |
On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > As slots and slot_width can be overwritter in case set_tdm() is > called. Avoid to have this logic in set_chan_cfg(). > > Instead pass the required values as params to set_chan_cfg().
It's not really clear here what the issue is, and how passing the slots and slot_width as arguments addresses it
> This also fix a bug when i2s->slot_width is set for TDM but not > properly used in set_chan_cfg().
Which bug?
Also, Fixes tag?
Thanks! Maxime
| |