Messages in this thread | | | Date | Mon, 21 Sep 2020 11:39:14 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer |
| |
On Fri, Sep 04, 2020 at 11:06:47AM -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > clang static analyzer reports this problem > > i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates > to a garbage value > return err ? err : num; > ^~~ > > err is not initialized, it depends on the being set in the > transfer loop which will not happen if num is 0. Surveying > other master_xfer() implementations show all handle a 0 num. > > Because returning 0 is expected, initialize err to 0. > > Signed-off-by: Tom Rix <trix@redhat.com>
Applied to for-next, thanks!
[unhandled content-type:application/pgp-signature] | |