Messages in this thread | | | From | jim.cromie@gmail ... | Date | Mon, 21 Sep 2020 21:57:22 -0600 | Subject | Re: [PATCH 1/2] dyndbg: dont panic over bad input |
| |
On Mon, Sep 21, 2020 at 1:29 PM Joe Perches <joe@perches.com> wrote: > > On Mon, 2020-09-21 at 13:04 -0600, Jim Cromie wrote: > > This BUG_ON, from 2009, caught the impossible case of a word-char both > > starting and ending a string (loosely speaking). A bad (reverted) > > patch finally hit this case, but even "impossibly bad input" is no > > reason to panic the kernel. Instead pr_err and return -EINVAL. > [] > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > [] > > @@ -259,7 +259,10 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords) > > } else { > > for (end = buf; *end && !isspace(*end); end++) > > ; > > - BUG_ON(end == buf); > > + if (end == buf) { > > + pr_err("expected non-empty bareword"); > > missing newline > > This message is also unintelligible. > What is a non-empty bareword? > >
hmm, I borrowed the term from perl
en.wiktionary.org › wiki › bareword (programming, chiefly Perl) A sequence of text characters in source code that do not form a keyword nor part of a quoted string, and may potentially be interpreted ...
basically, a not-quoted word, a keyword or not-quoted-value
Im open that there might be better terminology. have any suggestions ?
| |