lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 1/8] x86/cet/ibt: Add Kconfig option for user-mode Indirect Branch Tracking
Hi!

> > +config X86_INTEL_BRANCH_TRACKING_USER
> > + prompt "Intel Indirect Branch Tracking for user-mode"
>
> Take the "Intel " and "INTEL_" out, please. It will only cause us all
> pain later if some of our x86 compatriots decide to implement this.

Are other x86 manufacturers legally allowed to implement that?

> > If the kernel is to be used only on older systems that do not support
> > IBT, and the size of the binary is important, you can save 900 KB by
> > disabling this feature.
> >
> > Otherwise, if unsure, say Y.
>
> 900k seems like a *lot*. Where the heck does that come from?
>
> Also, comments like that don't age very well. Consider:
>
> Support for this feature is only known to be present on Intel
> processors released in 2020 or later. This feature is also
> known to increase kernel text size substantially.
>
> If unsure, say N.

That is much better, thanks.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-22 00:54    [W:0.935 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site