lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 05/46] drivers/net/wan/lapbether: Set network_header before transmitting
    Date
    From: Xie He <xie.he.0141@gmail.com>

    [ Upstream commit 91244d108441013b7367b3b4dcc6869998676473 ]

    Set the skb's network_header before it is passed to the underlying
    Ethernet device for transmission.

    This patch fixes the following issue:

    When we use this driver with AF_PACKET sockets, there would be error
    messages of:
    protocol 0805 is buggy, dev (Ethernet interface name)
    printed in the system "dmesg" log.

    This is because skbs passed down to the Ethernet device for transmission
    don't have their network_header properly set, and the dev_queue_xmit_nit
    function in net/core/dev.c complains about this.

    Reason of setting the network_header to this place (at the end of the
    Ethernet header, and at the beginning of the Ethernet payload):

    Because when this driver receives an skb from the Ethernet device, the
    network_header is also set at this place.

    Cc: Martin Schiller <ms@dev.tdt.de>
    Signed-off-by: Xie He <xie.he.0141@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wan/lapbether.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
    index 5befc7f3f0e7a..c6db9a4e7c457 100644
    --- a/drivers/net/wan/lapbether.c
    +++ b/drivers/net/wan/lapbether.c
    @@ -213,6 +213,8 @@ static void lapbeth_data_transmit(struct net_device *ndev, struct sk_buff *skb)

    skb->dev = dev = lapbeth->ethdev;

    + skb_reset_network_header(skb);
    +
    dev_hard_header(skb, dev, ETH_P_DEC, bcast_addr, NULL, 0);

    dev_queue_xmit(skb);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-21 18:33    [W:2.501 / U:1.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site