lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/18] bus: mhi: Remove include of rwlock_types.h
    Date
    From: Clark Williams <williams@redhat.com>

    rwlock.h should not be included directly. Instead linux/splinlock.h
    should be included. Including it directly will break the RT build.

    Also there is no point in including _types.h headers directly. There is
    no benefit in including the type without the accessor.

    Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers")
    Signed-off-by: Clark Williams <williams@redhat.com>
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    ---
    include/linux/mhi.h | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/include/linux/mhi.h b/include/linux/mhi.h
    index b2c0214bfbd6..008b8f6fa9ff 100644
    --- a/include/linux/mhi.h
    +++ b/include/linux/mhi.h
    @@ -9,10 +9,9 @@
    #include <linux/device.h>
    #include <linux/dma-direction.h>
    #include <linux/mutex.h>
    -#include <linux/rwlock_types.h>
    #include <linux/skbuff.h>
    #include <linux/slab.h>
    -#include <linux/spinlock_types.h>
    +#include <linux/spinlock.h>
    #include <linux/wait.h>
    #include <linux/workqueue.h>

    --
    2.17.1
    \
     
     \ /
      Last update: 2020-09-21 18:11    [W:4.148 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site