Messages in this thread | | | Date | Sun, 20 Sep 2020 18:59:33 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH -next v2] memory: emif: Convert to DEFINE_SHOW_ATTRIBUTE |
| |
On Thu, Sep 17, 2020 at 08:51:13PM +0800, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Along with this change, we get additionally: > .owner = THIS_MODULE, > .llseek = seq_lseek, > > 1. The llseek method is used to change the current read/write position > in a file which can be ignored if you don't use it. > 2. The owner is not even a method. Instead, it is a pointer to the > module that “owns” this structure; it is used by the kernel to maintain > the module's usage count which can be ignored. > > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> > --- > v2: based on linux-next(20200917), and can be applied to > mainline cleanly now. > > drivers/memory/emif.c | 22 ++--------------------
Thanks, applied.
Best regards, Krzysztof
| |