lkml.org 
[lkml]   [2020]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
From
Date
Hi again...

On 02/09/20 08:46, Luca Ceresoli wrote:
> Hi Sowjanya,
>
> On 02/09/20 04:04, Sowjanya Komatineni wrote:
>> This patch adds IMX274 optional external clock input and voltage
>> supplies to device tree bindings.
>>
>> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> .../devicetree/bindings/media/i2c/sony,imx274.yaml | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> index 7ae47a6..57e7176 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> @@ -25,6 +25,27 @@ properties:
>> reset-gpios:
>> maxItems: 1
>>
>> + clocks:
>> + maxItems: 1
>> + description: Reference to the sensor input clock
>> +
>> + clock-names:
>> + maxItems: 1
>> + items:
>> + - const: inck
>
> I think this can be simpler:
>
> clock-names:
> maxItems: 1
> items:
> - const: inck

Which is equal to the original... copy-paste-and-forgot.

Here's the simplified form, for real:

clocks:
maxItems: 1
clock-names:
const: inck

As in:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml?h=v5.9-rc3#n90


--
Luca

\
 
 \ /
  Last update: 2020-09-02 08:53    [W:0.240 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site