Messages in this thread | | | Date | Wed, 2 Sep 2020 17:29:32 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v3 -next] memory: omap-gpmc: Fix -Wunused-function warnings |
| |
On Tue, Sep 01, 2020 at 07:28:32PM +0800, YueHaibing wrote: > If CONFIG_OF is not set, make W=1 warns: > > drivers/memory/omap-gpmc.c:987:12: warning: ‘gpmc_cs_remap’ defined but not used [-Wunused-function] > static int gpmc_cs_remap(int cs, u32 base) > ^~~~~~~~~~~~~ > drivers/memory/omap-gpmc.c:926:20: warning: ‘gpmc_cs_get_name’ defined but not used [-Wunused-function] > static const char *gpmc_cs_get_name(int cs) > ^~~~~~~~~~~~~~~~ > drivers/memory/omap-gpmc.c:919:13: warning: ‘gpmc_cs_set_name’ defined but not used [-Wunused-function] > static void gpmc_cs_set_name(int cs, const char *name) > ^~~~~~~~~~~~~~~~ > Move them to #ifdef CONFIG_OF block to fix this. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v3: move the functions to #ifdef block > v2: update commit log > --- > drivers/memory/omap-gpmc.c | 114 ++++++++++++++++++-------------------
Thanks, applied.
Best regards, Krzysztof
| |