Messages in this thread | | | Date | Sat, 19 Sep 2020 14:17:01 -0700 (PDT) | Subject | Re: [PATCH net-next] net: neterion: Remove set but not used variable | From | David Miller <> |
| |
From: Zheng Yongjun <zhengyongjun3@huawei.com> Date: Sat, 19 Sep 2020 15:40:47 +0800
> @@ -179,7 +175,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_disable( > (u32)VXGE_HW_INTR_MASK_ALL, > &vp_reg->vpath_general_int_mask); > > - val64 = VXGE_HW_TIM_CLR_INT_EN_VP(1 << (16 - vpath->vp_id)); > + VXGE_HW_TIM_CLR_INT_EN_VP(1 << (16 - vpath->vp_id));
This makes no sense, this macro is calculating an integer value.
This looks like a mechanical change made without considering what the code is actually doing or should be doing.
| |