Messages in this thread | | | Date | Sat, 19 Sep 2020 14:10:54 -0700 (PDT) | Subject | Re: [PATCH net-next] net: natsemi: Remove set but not used variable | From | David Miller <> |
| |
From: Zheng Yongjun <zhengyongjun3@huawei.com> Date: Sat, 19 Sep 2020 10:46:44 +0800
> @@ -1226,8 +1226,8 @@ static int ns83820_get_link_ksettings(struct net_device *ndev, > > /* read current configuration */ > cfg = readl(dev->base + CFG) ^ SPDSTS_POLARITY; > - tanar = readl(dev->base + TANAR); > tbicr = readl(dev->base + TBICR); > + readl(dev->base + TANAR); >
Please do not change the order of the readl() operations, it might matter.
| |