lkml.org 
[lkml]   [2020]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] erofs: avoid unnecessary variable `err'
    Date
    variable `err' in z_erofs_submit_queue() isn't useful
    here, remove it instead.

    Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
    ---
    fs/erofs/zdata.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
    index 6c939def00f9..df6fa691097f 100644
    --- a/fs/erofs/zdata.c
    +++ b/fs/erofs/zdata.c
    @@ -1193,7 +1193,6 @@ static void z_erofs_submit_queue(struct super_block *sb,

    do {
    struct page *page;
    - int err;

    page = pickup_page_for_submission(pcl, i++, pagepool,
    MNGD_MAPPING(sbi),
    @@ -1219,8 +1218,7 @@ static void z_erofs_submit_queue(struct super_block *sb,
    ++nr_bios;
    }

    - err = bio_add_page(bio, page, PAGE_SIZE, 0);
    - if (err < PAGE_SIZE)
    + if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE)
    goto submit_bio_retry;

    last_index = cur;
    --
    2.18.1
    \
     
     \ /
      Last update: 2020-09-18 15:56    [W:3.214 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site