Messages in this thread | | | Date | Fri, 18 Sep 2020 10:36:18 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu/amd: Fix potential @entry null deref |
| |
On Thu, Sep 10, 2020 at 06:16:21PM +0100, Joao Martins wrote: > After commit 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after > programming IRTE"), smatch warns: > > drivers/iommu/amd/iommu.c:3870 amd_iommu_deactivate_guest_mode() > warn: variable dereferenced before check 'entry' (see line 3867) > > Fix this by moving the @valid assignment to after @entry has been checked > for NULL. > > Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > Fixes: 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after programming IRTE") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Joao Martins <joao.m.martins@oracle.com> > --- > drivers/iommu/amd/iommu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
Applied for v5.9, thanks.
| |