Messages in this thread | | | Date | Fri, 18 Sep 2020 17:31:28 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher |
| |
On Thu, Sep 17, 2020 at 06:35:55PM +0000, Corentin Labbe wrote: > Ciphers produce invalid results on BE. > Key and IV need to be written in LE. > Furthermore, the non-optimized function is too complicated to convert, > let's simply fallback on BE for the moment. > > Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") > Cc: <stable@vger.kernel.org> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-)
Does the BE failure get caught by the selftest?
If so please just leave it enabled so that it can be fixed properly.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |