lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 217/330] ubifs: ubifs_jnl_write_inode: Fix a memory leak bug
    Date
    From: Zhihao Cheng <chengzhihao1@huawei.com>

    [ Upstream commit 81423c78551654953d746250f1721300b470be0e ]

    When inodes with extended attributes are evicted, xent is not freed in one
    exit branch.

    Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
    Fixes: 9ca2d732644484488db3112 ("ubifs: Limit number of xattrs per inode")
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ubifs/journal.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
    index a6ae2428e4c96..5f2ac5ef0891e 100644
    --- a/fs/ubifs/journal.c
    +++ b/fs/ubifs/journal.c
    @@ -906,6 +906,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
    ubifs_err(c, "dead directory entry '%s', error %d",
    xent->name, err);
    ubifs_ro_mode(c, err);
    + kfree(xent);
    goto out_release;
    }
    ubifs_assert(c, ubifs_inode(xino)->xattr);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 05:01    [W:4.229 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site