lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 154/206] dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 8c149b7d75e53be47648742f40fc90d9fc6fa63a ]

    The required supplies in bindings were actually not matching
    implementation making the bindings incorrect and misleading. The Linux
    kernel driver requires all supplies to be present. Also for wlf,wm8994
    uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>).

    Reported-by: Jonathan Bakker <xc-racer2@live.ca>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20200501133534.6706-1-krzk@kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    .../devicetree/bindings/sound/wm8994.txt | 18 ++++++++++++------
    1 file changed, 12 insertions(+), 6 deletions(-)

    diff --git a/Documentation/devicetree/bindings/sound/wm8994.txt b/Documentation/devicetree/bindings/sound/wm8994.txt
    index 68cccc4653ba3..367b58ce1bb92 100644
    --- a/Documentation/devicetree/bindings/sound/wm8994.txt
    +++ b/Documentation/devicetree/bindings/sound/wm8994.txt
    @@ -14,9 +14,15 @@ Required properties:
    - #gpio-cells : Must be 2. The first cell is the pin number and the
    second cell is used to specify optional parameters (currently unused).

    - - AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply,
    - SPKVDD1-supply, SPKVDD2-supply : power supplies for the device, as covered
    - in Documentation/devicetree/bindings/regulator/regulator.txt
    + - power supplies for the device, as covered in
    + Documentation/devicetree/bindings/regulator/regulator.txt, depending
    + on compatible:
    + - for wlf,wm1811 and wlf,wm8958:
    + AVDD1-supply, AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply,
    + DCVDD-supply, CPVDD-supply, SPKVDD1-supply, SPKVDD2-supply
    + - for wlf,wm8994:
    + AVDD1-supply, AVDD2-supply, DBVDD-supply, DCVDD-supply, CPVDD-supply,
    + SPKVDD1-supply, SPKVDD2-supply

    Optional properties:

    @@ -73,11 +79,11 @@ wm8994: codec@1a {

    lineout1-se;

    + AVDD1-supply = <&regulator>;
    AVDD2-supply = <&regulator>;
    CPVDD-supply = <&regulator>;
    - DBVDD1-supply = <&regulator>;
    - DBVDD2-supply = <&regulator>;
    - DBVDD3-supply = <&regulator>;
    + DBVDD-supply = <&regulator>;
    + DCVDD-supply = <&regulator>;
    SPKVDD1-supply = <&regulator>;
    SPKVDD2-supply = <&regulator>;
    };
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:43    [W:3.305 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site