lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 175/206] usb: dwc3: Increase timeout for CmdAct cleared by device controller
    Date
    From: Yu Chen <chenyu56@huawei.com>

    [ Upstream commit 1c0e69ae1b9f9004fd72978612ae3463791edc56 ]

    If the SS PHY is in P3, there is no pipe_clk, HW may use suspend_clk
    for function, as suspend_clk is slow so EP command need more time to
    complete, e.g, imx8M suspend_clk is 32K, set ep configuration will
    take about 380us per below trace time stamp(44.286278 - 44.285897
    = 0.000381):

    configfs_acm.sh-822 [000] d..1 44.285896: dwc3_writel: addr
    000000006d59aae1 value 00000401
    configfs_acm.sh-822 [000] d..1 44.285897: dwc3_readl: addr
    000000006d59aae1 value 00000401
    ... ...
    configfs_acm.sh-822 [000] d..1 44.286278: dwc3_readl: addr
    000000006d59aae1 value 00000001
    configfs_acm.sh-822 [000] d..1 44.286279: dwc3_gadget_ep_cmd:
    ep0out: cmd 'Set Endpoint Configuration' [401] params 00001000
    00000500 00000000 --> status: Successful

    This was originally found on Hisilicon Kirin Soc that need more time
    for the device controller to clear the CmdAct of DEPCMD.

    Signed-off-by: Yu Chen <chenyu56@huawei.com>
    Signed-off-by: John Stultz <john.stultz@linaro.org>
    Signed-off-by: Li Jun <jun.li@nxp.com>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc3/gadget.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
    index 7bf2573dd459e..37cc3fd7c3cad 100644
    --- a/drivers/usb/dwc3/gadget.c
    +++ b/drivers/usb/dwc3/gadget.c
    @@ -270,7 +270,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd,
    {
    const struct usb_endpoint_descriptor *desc = dep->endpoint.desc;
    struct dwc3 *dwc = dep->dwc;
    - u32 timeout = 1000;
    + u32 timeout = 5000;
    u32 saved_config = 0;
    u32 reg;

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:41    [W:4.414 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site