Messages in this thread | | | Date | Thu, 17 Sep 2020 16:22:40 -0600 | From | Alex Williamson <> | Subject | Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver |
| |
On Thu, 17 Sep 2020 11:31:27 +0800 Zenghui Yu <yuzenghui@huawei.com> wrote:
> It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure > support") and actually unnecessary. Remove it.
Looks correct, but I might clarify as:
s/unnecessary/duplicates a forward declaration earlier in the file/
I can change on commit if you approve. Thanks,
Alex
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- > drivers/vfio/pci/vfio_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index 1ab1f5cda4ac..da68e2f86622 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -1862,7 +1862,6 @@ static const struct vfio_device_ops vfio_pci_ops = { > > static int vfio_pci_reflck_attach(struct vfio_pci_device *vdev); > static void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck); > -static struct pci_driver vfio_pci_driver; > > static int vfio_pci_bus_notifier(struct notifier_block *nb, > unsigned long action, void *data)
| |