lkml.org 
[lkml]   [2020]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support
From
Date


On 9/15/20 1:17 PM, Pratyush Yadav wrote:
> On 15/09/20 12:16PM, Vignesh Raghavendra wrote:
>>
>>
>> On 9/3/20 10:42 PM, Pratyush Yadav wrote:
>>> Hi,
>>>
>>> This series adds support for Octal DTR flashes in the SPI NOR framework,
>>> and then adds hooks for the Cypress Semper and Micron Xcella flashes to
>>> allow running them in Octal DTR mode. This series assumes that the flash
>>> is handed to the kernel in Legacy SPI mode.
>>>
>>> Tested on TI J721E EVM with 1-bit ECC on the Cypress flash.
>>>
>> [...]
>>
>> Please fix checkpatch issues on patch 1, 3, 4 and 5
>
> I ran checkpatch on my patches based on top of next-20200914 just now. I
> only see issues with patches 3 and 4. Patches 1 and 5 report no issues.
> What problems do you see on patches 1 and 5?
>

Please run with --strict argument to checkpatch. You can see the issues
at: https://pastebin.ubuntu.com/p/5pPWcGNsmp/

> As for patches 3 and 4, the error I see is "ENOTSUPP is not a SUSV4
> error code, prefer EOPNOTSUPP". I left it in intentionally. There a
> couple other functions in SPI NOR that use ENOTSUPP instead of
> EOPNOTSUPP so I followed the local convention.
>

This is a recent addition to checkpatch: 6b9ea5ff5abd ("checkpatch: warn
about uses of ENOTSUPP").

> If you insist, I can add a preparatory patch that first changes those
> uses of ENOTSUPP to EOPNOTSUPP and then update patches 3 and 4 to do the
> same. Let me know.
>

Changing existing usage of ENOTSUPP to EOPNOTSUPP is a separate exercise
and patches are welcome. But any new addition of ENOTSUPP would need to
be avoided.

Regards
Vignesh

\
 
 \ /
  Last update: 2020-09-16 08:18    [W:0.049 / U:2.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site