lkml.org 
[lkml]   [2020]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
Date
> -----Original Message-----
> From: Qinglang Miao <miaoqinglang@huawei.com>
> Sent: Wednesday, September 16, 2020 11:52 AM
> To: Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@marvell.com>; James E.J. Bottomley
> <jejb@linux.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Qinglang Miao
> <miaoqinglang@huawei.com>
> Subject: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
>
> External Email
>
> ----------------------------------------------------------------------
> The mutex bnx2i_dev_lock is initialized statically. It is unnecessary to
> initialize by mutex_init().
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 6018cdd17..2b3f0c104 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
> if (sq_size && !is_power_of_2(sq_size))
> sq_size = roundup_pow_of_two(sq_size);
>
> - mutex_init(&bnx2i_dev_lock);
> -
> bnx2i_scsi_xport_template =
> iscsi_register_transport(&bnx2i_iscsi_transport);
> if (!bnx2i_scsi_xport_template) {
> --

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>

\
 
 \ /
  Last update: 2020-09-16 11:17    [W:0.051 / U:6.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site