[lkml]   [2020]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v4 3/3] venus: core: add shutdown callback for venus
After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which may
lead to crash.

So implemented shutdown callback, which detach iommu maps.

Signed-off-by: Mansur Alisha Shaik <>
Acked-by: Stanimir Varbanov <>
Changes in V4:
- In venus_core_shutdown(), instead of venurs_remove() calling
venus_shutdown() and venus_firmware_deinit().
- With venus_remove() call during shutdown we are facing few issue
like ui freez this is because in venus_remove, hfi_core_deinit()
will wait until all core instances count become zero dudring

Changes in V3:
- Fix build errors

drivers/media/platform/qcom/venus/core.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 6103aaf..65b71ac 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -345,6 +345,14 @@ static int venus_remove(struct platform_device *pdev)
return ret;

+static void venus_core_shutdown(struct platform_device *pdev)
+ struct venus_core *core = platform_get_drvdata(pdev);
+ venus_shutdown(core);
+ venus_firmware_deinit(core);
static __maybe_unused int venus_runtime_suspend(struct device *dev)
struct venus_core *core = dev_get_drvdata(dev);
@@ -602,6 +610,7 @@ static struct platform_driver qcom_venus_driver = {
.of_match_table = venus_dt_match,
.pm = &venus_pm_ops,
+ .shutdown = venus_core_shutdown,

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
 \ /
  Last update: 2020-09-16 10:51    [W:0.053 / U:9.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site