lkml.org 
[lkml]   [2020]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 09/78] iio: adc: mcp3422: fix locking on error path
Hi!

> [ Upstream commit a139ffa40f0c24b753838b8ef3dcf6ad10eb7854 ]
>
> Reading from the chip should be unlocked on error path else the lock
> could never being released.
>
> Fixes: 07914c84ba30 ("iio: adc: Add driver for Microchip MCP3422/3/4 high resolution ADC")
> Fixes: 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope")

Well, 3f1093d83d71 is only applied later in the stable series, so this
introduces spurious unlock.

Ideally this should go just after 3f1093d83d71 ("iio: adc: mcp3422:
fix locking scope").

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-16 09:31    [W:0.345 / U:8.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site