lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning
On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote:
> I question the value of these warnings. Why even have a boolean type
> if you are going to get warnings when you use them...
> That said, applied to avoid getting these patches again and again
> every time someone sees this.

if (this_is_sparta)
if (this_is_sparta == true)
if (this_is_sparta != false)

I think the first one reads the best, and avoids having to
decide between truth and falsehood :)

>
> Alex
>
> On Wed, Sep 9, 2020 at 9:21 AM Christian König <christian.koenig@amd.com> wrote:
> >
> > Acked-by: Christian König <christian.koenig@amd.com> for the series.
> >
> > Am 09.09.20 um 15:07 schrieb Zheng Bin:
> > > Zheng Bin (8):
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in si.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in
> > > amdgpu_atpx_handler.c
> > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.c
> > >
> > > drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++--
> > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
> > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/si.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++--
> > > 8 files changed, 11 insertions(+), 11 deletions(-)
> > >
> > > --
> > > 2.26.0.106.g9fadedd
> > >
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Ville Syrjälä
Intel

\
 
 \ /
  Last update: 2020-09-15 21:39    [W:0.083 / U:9.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site