lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: net: Correct interrupt flags in examples
From
Date
On 9/8/20 4:59 PM, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
> Documentation/devicetree/bindings/net/nfc/nxp-nci.txt | 2 +-
> Documentation/devicetree/bindings/net/nfc/pn544.txt | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index 3613c2c8f75d..0968b40aef1e 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -33,7 +33,7 @@ tcan4x5x: tcan4x5x@0 {
> spi-max-frequency = <10000000>;
> bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>;
> interrupt-parent = <&gpio1>;
> - interrupts = <14 GPIO_ACTIVE_LOW>;
> + interrupts = <14 IRQ_TYPE_LEVEL_LOW>;
> device-state-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> device-wake-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;

For the tcan4x5x.txt:

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-15 08:27    [W:0.049 / U:3.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site