[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver
On di, 15 sep 2020 21:49:25 +0530, Manivannan Sadhasivam wrote:
> Hi,
> On Thu, Sep 10, 2020 at 07:08:00PM +0530, Manivannan Sadhasivam wrote:
> > Hello,
> Just a quick question: I don't see any activity on this specific driver for
> sometime (back in Martin days itself). Is it due to lack of reviewers or
> it is due to the patch size (lines of code) so that nobody is interested
> in reviewing?

If you look around, there are currently several versions of mcp251x
driver around, shipped by hardware vendors who glue the chip on there
SOM etc.
Until something more-or-less clean becomes mainline, the effort remains

A problem to import a complete driver is that ... its complete.
There was an suggestion to split into several patches, but that does not
really affect the review work.

The original driver failed to initialize under a loaded CAN bus, on my
desk. The current driver is more cleanly written than the original
and it seems to survive more than 1 use case (although I have a MAB overflow
report pending to investigate).
So, this is a good candidate for mainline.

Kind regards,

 \ /
  Last update: 2020-09-15 20:35    [W:0.091 / U:7.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site