lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: dt-bindings: Correct interrupt flags in examples
On Tue, 08 Sep 2020 16:59:54 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/sound/max98090.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5640.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5659.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5665.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5668.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5677.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5682.txt | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>

Acked-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2020-09-15 19:46    [W:0.056 / U:3.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site