lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema
From
Date
On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote:
> On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote:
> > Convert MediaTek IOMMU to DT schema.
> >
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---

[...]

> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt2701-m4u #mt2701 generation one HW
> > + - mediatek,mt2712-m4u #mt2712 generation two HW
> > + - mediatek,mt6779-m4u #mt6779 generation two HW
> > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW
>
> This is not right.
>
> items:
> - const: mediatek,mt7623-m4u
> - const: mediatek,mt2701-m4u
>
> And that has to be under a 'oneOf' with the rest of this.

Thanks for the review. Is this OK?

compatible:
oneOf:
- const: mediatek,mt2701-m4u # mt2701 generation one HW
- const: mediatek,mt2712-m4u # mt2712 generation two HW
- const: mediatek,mt6779-m4u # mt6779 generation two HW
- const: mediatek,mt8173-m4u # mt8173 generation two HW
- const: mediatek,mt8183-m4u # mt8183 generation two HW
- const: mediatek,mt8192-m4u # mt8192 generation two HW

- description: mt7623 generation one HW
items:
- const: mediatek,mt7623-m4u
- const: mediatek,mt2701-m4u

>
> > + - mediatek,mt8173-m4u #mt8173 generation two HW
> > + - mediatek,mt8183-m4u #mt8183 generation two HW
> > +
> > + reg:
> > + maxItems: 1

[snip]
\
 
 \ /
  Last update: 2020-09-15 07:52    [W:0.079 / U:12.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site