lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ASoC: tlv320aic32x4: Enable fast charge
On Tue, Sep 15, 2020 at 10:26:02AM +0200, Alexandre Belloni wrote:
> On 11/09/2020 19:31:40+0200, Miquel Raynal wrote:

> > + /*
> > + * Enable the fast charging feature and ensure the needed 40ms ellapsed
> > + * before using the analog circuits.
> > + */
> > + snd_soc_component_write(component, AIC32X4_REFPOWERUP,
> > + AIC32X4_REFPOWERUP_40MS);
> > + msleep(40);
> > +

> Maybe the actual REFPOWERUP value could be exposed as a control so
> userspace has a way to set the policy?

We very rarely do this, there's not usially anything

> I'm not sure it make sense to have the delay in probe because it is not
> enable the analog part of the codec. The delay should probable be after
> the clocks have been set up because the datasheet says that it is mdac
> and madc that is starting the analog circuitry.

Deferring the delay to a workqueue is the usual thing where there's
concerns about slowing down boot.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-15 14:05    [W:0.038 / U:5.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site