lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system
On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang <qiangqing.zhang@nxp.com> wrote:
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: 2020年9月15日 15:18
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: sean@mess.org; mchehab@kernel.org; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system
> On Tuesday, September 15, 2020, Joakim Zhang <qiangqing.zhang@nxp.com> wrote:




> + ret = pm_runtime_get(dev);
> + if (ret < 0)
>
>
>
> Here is reference counter leak.
>
>
>
> Thanks Andy for your kindly review.
>
> pm_runtime_get increase the usage_count even it fails, so need call pm_runtime_put_noidle here to balance the usage_count. Am I right?

Yes.

> + return IRQ_NONE;


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-09-15 12:53    [W:0.074 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site