[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap()
Eric W. Biederman <> wrote:
> linmiaohe <> writes:
>> Eric W. Biederman <> wrote:
>>> Miaohe Lin <> writes:
>>>> Use helper function mapping_allow_writable() to atomic_inc
>>>> i_mmap_writable.
>> Because I think it's better to use the wrapper function instead of the
>> open hard code.
>My point is there is no context in this commit message.
>What makes it better to use the wrapper function?
>What makes the wrapper function the appropriate function to use?
>Why just this location?
>Why wasn't this change made when the wrapper function was introduced?
>I could probably read through the code and figure these things out but the description of the change should really include these things.

I see. Many thanks for your detailed explaination. :)

 \ /
  Last update: 2020-09-15 11:26    [W:0.024 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site